tisonkun commented on PR #136: URL: https://github.com/apache/datasketches-rust/pull/136#issuecomment-4613682295
> My only concern is that all the functions use the same name but some report only heap memory while others report stack + heap. This could be confusing although we mention in the comment. This is why we use `estimated_bytes` as the name. I'll review all the impl and consider whether it is a reasonable estimation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
