tisonkun commented on code in PR #136:
URL: https://github.com/apache/datasketches-rust/pull/136#discussion_r3332503064
##########
datasketches/src/hll/array4.rs:
##########
@@ -425,6 +425,16 @@ impl Array4 {
bytes.into_bytes()
}
+
+ /// Returns the estimated size of the heap allocations in bytes
+ pub fn estimated_size(&self) -> usize {
+ self.bytes.len()
+ + self
+ .aux_map
+ .as_ref()
+ .map(|a| a.estimated_size())
+ .unwrap_or(0)
+ }
Review Comment:
nit: can add but not necessay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
