tisonkun commented on code in PR #136:
URL: https://github.com/apache/datasketches-rust/pull/136#discussion_r3332499619
##########
datasketches/src/hll/sketch.rs:
##########
@@ -423,6 +423,19 @@ impl HllSketch {
Mode::Array8(arr) => arr.serialize(self.lg_config_k),
}
}
+
+ /// Returns the estimated size of the sketch in bytes
+ pub fn estimated_size(&self) -> usize {
+ let heap_size = match &self.mode {
+ Mode::List { list, .. } => list.container().estimated_size(),
+ Mode::Set { set, .. } => set.container().estimated_size(),
+ Mode::Array4(arr) => arr.estimated_size(),
+ Mode::Array6(arr) => arr.estimated_size(),
+ Mode::Array8(arr) => arr.estimated_size(),
+ };
+
+ std::mem::size_of::<Self>() + heap_size
+ }
Review Comment:
Nope. Using `estimated_size` should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
