tabac commented on PR #136: URL: https://github.com/apache/datasketches-rust/pull/136#issuecomment-4572032940
> Generally LGTM. > > I have two comments: > > 1. Naming is important. We can spend a few more time on considering names. So far, I may prefer `estimated_bytes` because (1) it clearly describes the unit is bytes (2) we may not always have the accurate size so leaving it as a hint should be better; this is what this info is typically used IMO. (Disclose: the name `estimated_bytes` is used by ScopeDB for similar cases.) Makes sense to me, just to make a couple of naming suggestions: `estimated_size_bytes` is one, the other being `mem_footprint` but I prefer the first one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
