On 12/19/2013, 9:40 PM, Nicholas Nethercote wrote:
On Thu, Dec 19, 2013 at 6:32 PM, Chris Peterson <cpeter...@mozilla.com> wrote:
I like #3. The common style subset is probably small, but since it is
common, it will be uncontroversial and require no bikeshedding. :)
I suspect it would be tiny. I recently had to move a function from
SpiderMonkey to Gecko. It was probably 50 lines of code, and I had to
change almost every line. SpiderMonkey and Gecko styles differ
tremendously, alas.
Yes, which is why I like option #4. To be very specific, here's a
number of examples of things which our code base doesn't agree on:
1. Line endings
2. The amount of indentation
3. Naming things, such as classes, functions, member variables,
arguments, etc
4. Placement of braces
5. Include guards
6. Order of include statements
Already we're past the point of option #3 being worth it IMO.
Cheers,
Ehsan
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
