I mistakenly sent this only to Jeff: On Thu, Dec 19, 2013 at 6:29 PM, Ehsan Akhgari <ehsan.akhg...@gmail.com>wrote:
> On 12/19/2013, 5:29 PM, Jeff Gilbert wrote: > >> It's compromise. I think we can take it as given that we'll never all >> agree on one way to do things, so instead, different modules do their own >> things. I think this is a pretty decent solution, though the problem >> becomes needing different guides for different modules. (the "just mime >> what you see" is...imperfect) >> > > Well, you're making it sound like code under gfx/ follows a single style, > but it doesn't. Here is one example from two random files that I just > opened: gfx/gl/GLContext.cpp uses 4 space indentation, gfx/layers/Layers.h > uses 2 space indentation. > > > I posit that there's probably not much benefit to having, say, style for >> dom/ match style for gfx/, since precious-few people often deal with both >> at once. >> > > Well, I think that depends on how much you value consistency across the > code base. Like I said, there are two camps here. What I'm advocating is > not for _my_ style to be used by everybody, but for _a_ style to be used by > everybody. > > Cheers, > Ehsan > > To which he replied: Yeah, gfx/ and gfx/gl/ have two different (though consistent) styles. In my experience, it hasn't been a problem to work with. The only annoying bit is when my editor doesn't pick up on whether the file's 2-space or 4-space. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
