On Fri, Dec 20, 2013 at 2:35 PM, Jeff Gilbert <jgilb...@mozilla.com> wrote:
> Personally, there are a couple of things I don't like about moz-style > (though revisions to the central style guide at least have made it better > than it used to be), but instead of bikeshedding the central style guide, > we just do our own thing in the code we're responsible for. > That's a mistake. Module owners don't have the authority to make up their own style. Who has been doing this? I suppose my counter-question is 'How does standardizing styles across > modules help us?' In my experience, reviewing (or being reviewed) for style > takes almost no time. It's definitely dwarfed by the time I need to spend > thinking about the changes being made to the code. I think readability > improvements (for those who actually work on the code in question) are more > important than the code looking exactly the same as code from a module I've > never even opened. > As someone who writes and reviews code across a lot of modules, I strongly disagree. You may have the luxury of working strictly within a very small part of our code, but if so, please don't generalize from your experience, and I don't think we should be optimizing for you. If you think you have modifications to our style guide that objectively improve code readability, please propose them. I'd love to discover some, but I'm skeptical they exist :-). Rob -- Jtehsauts tshaei dS,o n" Wohfy Mdaon yhoaus eanuttehrotraiitny eovni le atrhtohu gthot sf oirng iyvoeu rs ihnesa.r"t sS?o Whhei csha iids teoa stiheer :p atroa lsyazye,d 'mYaonu,r "sGients uapr,e tfaokreg iyvoeunr, 'm aotr atnod sgaoy ,h o'mGee.t" uTph eann dt hwea lmka'n? gBoutt uIp waanndt wyeonut thoo mken.o w _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
