On 12/19/13, 5:35 PM, Jeff Gilbert wrote:
The last bit of the problem is that*all of Gecko* is currently 'files with
existing styles', so I'm not sure how that can mesh with having 'one true
style' unless we have an initiative to actually convert over all mis-styled
files.
If we either fail to convert large parts of Gecko, or fail to address concerns
people have, we're just going to end up with the same style fiefdoms we already
have.
Here is a list of the options I see:
1. Do nothing.
2. Define and enforce existing per-module styles.
3. Define an ideal global style but enforce only the *subset* that is
common across all modules. Gradually migrate modules to the ideal style
like we have migrated modules to use mozbuild's FAIL_ON_WARNINGS.
4. Define an ideal global style and enforce across all modules. Restyle
the entire tree in one flag day! This would hurt, but the pain of patch
bitrotting would be short. This approach is probably impractical.
By "enforce", I mean with a lint check that causes local build errors
for style violations (but does not necessarily turn the tree orange on
TBPL).
I like #3. The common style subset is probably small, but since it is
common, it will be uncontroversial and require no bikeshedding. :)
chris
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
