Hi Sean,

Sean Whitton <spwhit...@spwhitton.name> writes:

> Hello,
>
> On Fri 13 Dec 2024 at 11:36pm -08, Xiyue Deng wrote:
>
>> I also tried d/install, but it cannot rename files.
>
> You could try dh_exec.
>
>> In fact, all Debian control files supporting the "source destination"
>> format seem to treat destination as a directory only and are created
>> on demand, which I think makes sense.  I think manually using
>> install/rename the file in override_dh_installdocs will interfere with
>> the automatic handling of dh_* tools anyway and I'd like to avoid
>> that.
>
> I don't think it will interfere with anything.  Just
>
>     override_dh_installdocs:
>         install ...
>         dh_installdocs
>
> should be fine.
>

This works, though I kinda like retaining CHANGELOG.org which is an
upstream file anyway.  But see my next question.

>> So instead, I opt for one of the previous ideas: install changelog as a
>> symlink of CHANGELOG.org in d/links, which should take care of all the
>> unnecessary renaming dance.  However, it triggers another lintian
>> warning "debian-changelog-file-is-a-symlink", which it should not as the
>> document says if the file is under /usr/share/doc/*pkg* it should be
>> fine, which CHANGELOG.org is.  Anyway, I added a lintian override for
>> that for now and will file a follow up bug to track this false positive
>> case on lintian.
>
> I think Lintian is correct, tbh.
>

Can you expand a little on this?  The lintian warning text does say:
,----
| (Symlinks to another file in /usr/share/doc/pkg or a subdirectory
| thereof are fine and should not trigger this warning.)
`----
which I believe CHANGELOG.org satisfies.

>> I took a look at the machine-readable copyright format document[1],
>> specifically the example given in the copyright section 6.8, and I
>> think it meant that if a group of file shares any copyright holder(s),
>> those files can be grouped in the same stanza - in the example, Angela
>> Watts appeared in both source files so those files can share the same
>> stanza.  I think in the case for dap-mode, each file has only a single
>> copyright holder so may be this simplification doesn't apply, so I opt
>> to provide separate stanza for all files.  I surely hope I can list
>> everyone under "Files: *" so that things can be simpler, but keeping it
>> as-is just in case.
>
> They can definitely be grouped in the way I suggested.
>

As Soren explained in details, I think a single "Files: *" stanza should
be OK, right?

> -- 
> Sean Whitton

-- 
Regards,
Xiyue Deng

Attachment: signature.asc
Description: PGP signature

Reply via email to