Hi Sean, Sean Whitton <spwhit...@spwhitton.name> writes:
> Hello, > > On Sun 15 Dec 2024 at 01:19am -08, Xiyue Deng wrote: > >>> I think Lintian is correct, tbh. >> >> Can you expand a little on this? The lintian warning text does say: >> ,---- >> | (Symlinks to another file in /usr/share/doc/pkg or a subdirectory >> | thereof are fine and should not trigger this warning.) >> `---- >> which I believe CHANGELOG.org satisfies. > > I should have been more explicit. I think that Lintian is right that > this file should not be a symlink; I did not mean to comment on whether > or not there is a bug in the check. > > When Policy calls for a file to be installed at /a/b/c and upstream ship > that file under the name foo-1.0/d/e.f, we install it directly as > /a/b/c. > > Doing anything else would need a good justification -- for example, that > overall the d/rules is simpler. (Suppose upstream's build system > already installed the changelog under /usr/share/doc, well, then we > might make our changelog file a symlink to it.) > > This is not the case here, so far as I can see. > > It's important to remember that upstream's context is different to ours. > This is Free Software; we should patch things and move them around as > appropriate to our context. > Thanks for the extended explanations. I think what you said makes sense. In the context of ELPA based packages, the FHS is not followed as everything is installed under `(concat user-emacs-directory "elpa")', and usually we use d/docs to include CHANGELOG.org to put it in /usr/share/doc/*pkg*. This makes it harder for me to argue that putting it in that directory is intended by upstream :( To look at it from complexity point of view, installing CHANGELOG.org as changelog requires the following minimum change: 1) Not included CHANGELOG.org in d/docs (which now only includes NEWS.org), 2) Override dh_installdocs to install CHANGELOG.org as changelog, while using a symlink from changelog to CHANGELOG.org requires: 1) Include CHANGELOG.org in d/docs, 2) Add linking to changelog in d/links, 3) Compress CHANGELOG.org by overriding dh_installdocs as it's not compressed by default and it's required for changelog.gz, 4) Add a lintian override for that what-I-think-is-a-false-positive tag. So the former wins here, and I have implemented it now in Salsa. [ On the other hand, I think using CHANGELOG.org is becoming a common practice in many ELPA packages and it should be considered a supported format for changelog. I'll probably follow-up on this in another bug to see if this would be acceptable, so that step 2-4 of the latter won't be required. What would be a good place to file such a wishlist bug? ] >> As Soren explained in details, I think a single "Files: *" stanza >> should be OK, right? > > I haven't read Soren's mail. If you mean that a single "Files: *" for > all the GPL-3+ licensed files, then yes, that should be fine. > Ack. > I saw that you reformatted copyright claims to drop the (C) and to add > commas. Generally licenses require us to reproduce copyright notices > verbatim. IANAL, but reformatting is probably not justified. > Ack. It looks like policy 12.5 does say copyright information should be verbatim, however as we can group the copyright holder spanning multiple years, it becomes "not-verbatim" then. Oh well, guess nothing is perfect. > You'll need a copy of the entire EPL-2.0, per Policy 12.5. > Lintian warns about not including CC-BY-SA-4.0 full text but doesn't warn about EPL-2.0. Anyway, I think including the full text is the safe bet and this has been done. PTAL. > -- > Sean Whitton -- Regards, Xiyue Deng
signature.asc
Description: PGP signature
