On Mon, 29 Sep 2025 23:55:55 GMT, Alexander Matveev <[email protected]>
wrote:
>> test/jdk/tools/jpackage/macosx/CustomInfoPListTest.java line 143:
>>
>>> 141:
>>> 142: MacHelper.withExplodedDmg(cmd, dmgImage -> {
>>> 143: if (dmgImage.endsWith(cmd.name() + ".jdk")) {
>>
>> Isn't this test redundant?
>
> No. This function is called for all files in DMG such as
> `/Volumes/foo/.background`.
Ah, ok. I see this sort of check in 5 locations.
I guess if you replace `dmgImage.endsWith(cmd.name() + ".jdk")` with
`dmgImage.endsWith(cmd.appInstallationDirectory().getFileName())` it will
become self-explanatory.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27509#discussion_r2389597491
