On Fri, 26 Sep 2025 11:41:44 GMT, Alexey Semenyuk <[email protected]> wrote:
>> - Added test for custom info plist to cover app image including embedded
>> runtime and runtime installer.
>> - Fixed bug in `writePList`. It was missing
>> `writeStartDocument()/writeEndDocument()` and `DOCTYPE` should be full xml
>> string.
>
> test/jdk/tools/jpackage/macosx/CustomInfoPListTest.java line 70:
>
>> 68:
>> 69: // We do not need full Info.plist for testing
>> 70: private static String getInfoPListXML(String bundleName) {
>
> Use jdk.jpackage.internal.util.XmlUtils.createXml() helper to create xml
> file. It will format the output xml and will also eliminate the need for the
> patch in PListWriter class.
Should I remove `writePList()` since it is broken and it is not used?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27509#discussion_r2389521050
