On Fri, 26 Sep 2025 02:54:32 GMT, Alexander Matveev <[email protected]>
wrote:
> - Added test for custom info plist to cover app image including embedded
> runtime and runtime installer.
> - Fixed bug in `writePList`. It was missing
> `writeStartDocument()/writeEndDocument()` and `DOCTYPE` should be full xml
> string.
test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacHelper.java line 178:
> 176: }
> 177:
> 178: public static Path createInputRuntimeImage() throws IOException {
This is not mac-specific helper function. You'd rather move it to
JPackageCommand class.
BTW, there is a bunch of `createInputRuntimeImage()` functions already:
-
https://github.com/openjdk/jdk/blob/7bfdb0120752d01da96c19e8037a6e909847d63c/test/jdk/tools/jpackage/macosx/SigningRuntimeImagePackageTest.java#L97
-
https://github.com/openjdk/jdk/blob/7bfdb0120752d01da96c19e8037a6e909847d63c/test/jdk/tools/jpackage/share/RuntimePackageTest.java#L176
-
https://github.com/openjdk/jdk/blob/7bfdb0120752d01da96c19e8037a6e909847d63c/test/jdk/tools/jpackage/share/RuntimeImageTest.java#L51
Instead of adding another one, let's consolidate them in one.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27509#discussion_r2382089629
