On Fri, 26 Sep 2025 11:44:18 GMT, Alexey Semenyuk <[email protected]> wrote:
>> - Added test for custom info plist to cover app image including embedded
>> runtime and runtime installer.
>> - Fixed bug in `writePList`. It was missing
>> `writeStartDocument()/writeEndDocument()` and `DOCTYPE` should be full xml
>> string.
>
> test/jdk/tools/jpackage/macosx/CustomInfoPListTest.java line 143:
>
>> 141:
>> 142: MacHelper.withExplodedDmg(cmd, dmgImage -> {
>> 143: if (dmgImage.endsWith(cmd.name() + ".jdk")) {
>
> Isn't this test redundant?
No. This function is called for all files in DMG such as
`/Volumes/foo/.background`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27509#discussion_r2389527448
