On Fri, 26 Sep 2025 02:54:32 GMT, Alexander Matveev <[email protected]>
wrote:
> - Added test for custom info plist to cover app image including embedded
> runtime and runtime installer.
> - Fixed bug in `writePList`. It was missing
> `writeStartDocument()/writeEndDocument()` and `DOCTYPE` should be full xml
> string.
test/jdk/tools/jpackage/macosx/CustomInfoPListTest.java line 70:
> 68:
> 69: // We do not need full Info.plist for testing
> 70: private static String getInfoPListXML(String bundleName) {
Use jdk.jpackage.internal.util.XmlUtils.createXml() helper to create xml file.
It will format the output xml and will also eliminate the need for the patch in
PListWriter class.
test/jdk/tools/jpackage/macosx/CustomInfoPListTest.java line 143:
> 141:
> 142: MacHelper.withExplodedDmg(cmd, dmgImage -> {
> 143: if (dmgImage.endsWith(cmd.name() + ".jdk")) {
Isn't this test redundant?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27509#discussion_r2382127433
PR Review Comment: https://git.openjdk.org/jdk/pull/27509#discussion_r2382137024
