On Tue, 25 Mar 2025 16:41:41 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47 additional commits >> since the last revision: >> >> - Merge branch 'openjdk:master' into JDK-8319447 >> - Match indent of naster changes >> - Use TC_MASK in accord with https://bugs.openjdk.org/browse/JDK-8330017 >> (Unnecessarily for now.) >> - Reword javadoc >> - Use SharedSecrets for ThreadLocalRandomProbe; other tweaks >> - Disambiguate caller-runs vs Interruptible >> - Merge branch 'openjdk:master' into JDK-8319447 >> - Associate probes with carriers if Virtual (no doc updates yet) >> - Reduce volatile reads >> - Address review comments; reactivation tweak >> - ... and 37 more: https://git.openjdk.org/jdk/compare/95474107...b552c225 > > test/jdk/java/util/concurrent/tck/ForkJoinPool20Test.java line 458: > >> 456: } >> 457: previous.set(now); >> 458: done.countDown(); > > Should we test so that we don't count down below 0? Sure. Added assertTrue(done.getCount() > 0); before done.countDown(); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r2012772294
