On Tue, 25 Mar 2025 15:30:22 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47 additional commits >> since the last revision: >> >> - Merge branch 'openjdk:master' into JDK-8319447 >> - Match indent of naster changes >> - Use TC_MASK in accord with https://bugs.openjdk.org/browse/JDK-8330017 >> (Unnecessarily for now.) >> - Reword javadoc >> - Use SharedSecrets for ThreadLocalRandomProbe; other tweaks >> - Disambiguate caller-runs vs Interruptible >> - Merge branch 'openjdk:master' into JDK-8319447 >> - Associate probes with carriers if Virtual (no doc updates yet) >> - Reduce volatile reads >> - Address review comments; reactivation tweak >> - ... and 37 more: https://git.openjdk.org/jdk/compare/02bc9fe1...b552c225 > > src/java.base/share/classes/java/util/concurrent/DelayScheduler.java line 501: > >> 499: } >> 500: >> 501: // InterruptibleTask methods > > @DougLea I think a few methods below should have Override annotations. Not sure of conventions for overrides of non-public methods. The internal FJT classes only contain them, and I uniformly omit annotations. Do they add any value? > src/java.base/share/classes/java/util/concurrent/ForkJoinTask.java line 1813: > >> 1811: for (Callable<T> c : tasks) { >> 1812: if (c == null) >> 1813: throw new NullPointerException(); > > @DougLea Objects.requireNonNull(c) ? Sure. Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r2012740636 PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r2012742684
