On Wed, 26 Mar 2025 13:11:40 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 49 commits: >> >> - Merge branch 'openjdk:master' into JDK-8319447 >> - Address review comments >> - Merge branch 'openjdk:master' into JDK-8319447 >> - Match indent of naster changes >> - Use TC_MASK in accord with https://bugs.openjdk.org/browse/JDK-8330017 >> (Unnecessarily for now.) >> - Reword javadoc >> - Use SharedSecrets for ThreadLocalRandomProbe; other tweaks >> - Disambiguate caller-runs vs Interruptible >> - Merge branch 'openjdk:master' into JDK-8319447 >> - Associate probes with carriers if Virtual (no doc updates yet) >> - ... and 39 more: https://git.openjdk.org/jdk/compare/dbc620fb...4aabe6b0 > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3743: > >> 3741: * @since 25 >> 3742: */ >> 3743: public void cancelDelayedTasksOnShutdown() { > > @DougLea Should this really be possible to enable for the common pool? > (Because different parts of an application using commonPool() could have > conflicting requirements) The commonPool can't be shutdown (both shutdown methods are specified to have no effect on the common pool) so I suppose it doesn't really matter. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r2014119265