On Tue, 25 Mar 2025 15:40:08 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47 additional commits >> since the last revision: >> >> - Merge branch 'openjdk:master' into JDK-8319447 >> - Match indent of naster changes >> - Use TC_MASK in accord with https://bugs.openjdk.org/browse/JDK-8330017 >> (Unnecessarily for now.) >> - Reword javadoc >> - Use SharedSecrets for ThreadLocalRandomProbe; other tweaks >> - Disambiguate caller-runs vs Interruptible >> - Merge branch 'openjdk:master' into JDK-8319447 >> - Associate probes with carriers if Virtual (no doc updates yet) >> - Reduce volatile reads >> - Address review comments; reactivation tweak >> - ... and 37 more: https://git.openjdk.org/jdk/compare/70380108...b552c225 > > test/jdk/java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java > line 51: > >> 49: var future = new CompletableFuture<>().orTimeout(12, >> TimeUnit.HOURS); >> 50: future.completeExceptionally(new RuntimeException("This is >> fine")); >> 51: while (delayer.getDelayedTaskCount() != 0) { > > Should this not check `> 0`? 🤔 Thanks, done. > test/jdk/java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java > line 65: > >> 63: var future = new CompletableFuture<>().completeOnTimeout(null, >> 12, TimeUnit.HOURS); >> 64: future.completeExceptionally(new RuntimeException("This is >> fine")); >> 65: while (delayer.getDelayedTaskCount() != 0) { > > Should this not check > 0? 🤔 Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r2012750415 PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r2012750966
