On Tue, 17 Dec 2024 11:45:56 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` >> without explicit `--module-path` option or a non-existent module path. In >> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and >> `--limit-modules` are used in combination. It failed earlier and passes now >> due to alignment of `ModuleFinder`s. With this patch JEP 493 enabled builds >> and regular JDK builds behave the same in terms of `ALL-MODULE-PATH`. >> >> When an explicit module path is being added, there is no difference. All >> modules on that path will be added as roots. Tests have been added for the >> various cases and existing tests updated to allow for them to run on JEP 493 >> enabled builds. Thoughts? >> >> Testing: >> - [x] GHA, `test/jdk/tools/jlink` (all pass) >> - [x] Added jlink test. > > Severin Gehwolf has updated the pull request incrementally with one > additional commit since the last revision: > > Fix comments The combination of ALL-MODULE-PATH and `--limit-modules` indeed needs time to discuss. As the tests work with the current fix, we should separate this issue and revisit this in the future. I have reviewed the version before the commit to check proactively any dependence not observable [bfac446](https://github.com/openjdk/jdk/pull/22494/commits/bfac44659e7219afe472d0e61735df119065796d). The resolution will fail anyway and this eager verification is not needed IMO. What do you think? ------------- PR Comment: https://git.openjdk.org/jdk/pull/22494#issuecomment-2549773554
