On Mon, 16 Dec 2024 17:23:15 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` >> without explicit `--module-path` option or a non-existent module path. In >> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and >> `--limit-modules` are used in combination. It failed earlier and passes now >> due to alignment of `ModuleFinder`s. With this patch JEP 493 enabled builds >> and regular JDK builds behave the same in terms of `ALL-MODULE-PATH`. >> >> When an explicit module path is being added, there is no difference. All >> modules on that path will be added as roots. Tests have been added for the >> various cases and existing tests updated to allow for them to run on JEP 493 >> enabled builds. Thoughts? >> >> Testing: >> - [x] GHA, `test/jdk/tools/jlink` (all pass) >> - [x] Added jlink test. > > Severin Gehwolf has updated the pull request incrementally with one > additional commit since the last revision: > > Catch case of module not in dependency tree Just on --add-modules ALL-MODULE-PATH with --limit-modules. This combination isn't implemented at run-time, I think we just missed it at the time. In practical terms it's not interesting of course but just mentioning it here because I don't think jlink with --add-modules ALL-MODULE-PATH and --limit-modules is interesting either. The main thing to deal with here is --add-modules ALL-MODULE-PATH without --module-path so I'll focus on that part. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22494#issuecomment-2548207813
