On Sun, 26 Mar 2023 16:51:28 GMT, Martin Buchholz <mar...@openjdk.org> wrote:
>> So, what I would suggest is adding a comment somewhere regarding _end of >> central directory record_ and note the reference to _ENDHDR_ or _END Header_ >> >> I don't think you want to spend too much time here just the wording >> reference the _end of central directory record_ was clear and where you were >> abbreviating, then I would reference ENDHDR >> >> I would be looking at the APP.NOTE when looking at this test, not the >> ZipFile constant verbiage, but that is just me :-) > > Neither APPNOTE nor JDK doc zip terminology is great, but a test is not the > place to invent something better. > > (But I'm surprised no one seems to be using "EOCD") I think that would be “EOCDR”. (Hides behind the bike shed..) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12231#discussion_r1148595939
