On Fri, 24 Mar 2023 18:30:26 GMT, Martin Buchholz <mar...@openjdk.org> wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Remove @throws as per review feedback >> - Consistently use the term "END header" when referring to the "End of >> central directory record". >> - Remove "the the" repetition > > test/jdk/java/util/zip/ZipFile/EndOfCenValidation.java line 139: > >> 137: * Validate that an end of central directory record with a CEN >> offset which >> 138: * is larger than the EOC position minus the CEN size is rejected >> 139: * @throws IOException > > I don't think `@throws` javadoc comments in tests are useful; especially > checked ones I recently added a `@throws` by review comment from Lance. I tend to agree that is not very useful, so I'm removing both ocurrences as per your recommendation. If Lance wants it back, he can add a review comment saying so. I don't particularly care which professor gets the last word in this matter :-) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12231#discussion_r1148317170
