On Fri, 24 Mar 2023 18:28:36 GMT, Martin Buchholz <mar...@openjdk.org> wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Remove @throws as per review feedback >> - Consistently use the term "END header" when referring to the "End of >> central directory record". >> - Remove "the the" repetition > > test/jdk/java/util/zip/ZipFile/EndOfCenValidation.java line 120: > >> 118: /** >> 119: * Validate that an end of central directory record with a >> 120: * CEN size which exceeds the position of the EOC record is >> rejected. > > EOC is not a standard zip file technical term. Did you mean "END header" ? If by "standard" you mean "APPNOTE.TXT", then that uses "end of central directory record" which is a bit long. The Java implementation seems to use END, like in `ZipFile.ENDHDR`, "END header", etc. It is probably better to be consistent than correct here, so I've changed the test to use "END header" consistently when referring to the "end of central directory record". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12231#discussion_r1148316828
