On Sat, 25 Mar 2023 06:46:22 GMT, Eirik Bjorsnos <d...@openjdk.org> wrote:
>> test/jdk/java/util/zip/ZipFile/EndOfCenValidation.java line 120: >> >>> 118: /** >>> 119: * Validate that an end of central directory record with a >>> 120: * CEN size which exceeds the position of the EOC record is >>> rejected. >> >> EOC is not a standard zip file technical term. Did you mean "END header" ? > > If by "standard" you mean "APPNOTE.TXT", then that uses "end of central > directory record" which is a bit long. > > The Java implementation seems to use END, like in `ZipFile.ENDHDR`, "END > header", etc. > > It is probably better to be consistent than correct here, so I've changed the > test to use "END header" consistently when referring to the "end of central > directory record". So, what I would suggest is adding a comment somewhere regarding _end of central directory record_ and note the reference to _ENDHDR_ or _END Header_ I don't think you want to spend too much time here just the wording reference the _end of central directory record_ was clear and where you were abbreviating, then I would reference ENDHDR I would be looking at the APP.NOTE when looking at this test then the ZipFile constant verbiage, but that is just me :-) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12231#discussion_r1148350853
