DanielLeens commented on PR #13083:
URL: https://github.com/apache/seatunnel/pull/13083#issuecomment-6624359548

   Thanks @sharpca for the clear updates, and no worries at all about the wait.
   
   - Issue 5: leaving the `//` comment block as is is fine with me.
   - CI: I can confirm the state you describe. Fork run 
https://github.com/sharpca/seatunnel/actions/runs/41730993933 on `de80d166` is 
still `queued` with no update since 00:22Z, so it cannot produce the green 
result needed for merge, even though the part-8 shard you quoted already shows 
`testFixedStringSplitBoundsAreLocaleIndependent` passing and the only error 
there being the unrelated `MetalakeIT` startup timeout.
   
   Lowest-cost next step once Actions is enabled on your fork again: rather 
than rerunning the wedged run, start a fresh `Build` by hand from your fork's 
Actions tab ("Run workflow" on `fix/jdbc-type-converter-locale`). 
`build_main.yml` supports `workflow_dispatch` 
(`.github/workflows/build_main.yml:25-28`), so this runs on the same head 
`de80d166` and no empty commit is needed; my review of this head stays valid. 
If the old run is still listed as queued, you can ignore it.
   
   Separately, the apache-side `PR signal` run for this head 
(https://github.com/apache/seatunnel/actions/runs/41731002878) is 
`action_required` with 0 jobs, which is why no `Build` check is attached to the 
PR yet. That needs a committer with write access to approve the workflow run; I 
only have read access, so I cannot do it myself. Nothing is needed from you for 
that part.
   
   As soon as a fork `Build` on `de80d166` completes green (allowing for 
clearly unrelated flakes such as `MetalakeIT` or the Doris IT, which can be 
rerun), I will update my review to approve. Thanks again!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to