sharpca commented on PR #13083: URL: https://github.com/apache/seatunnel/pull/13083#issuecomment-6555105061
Added a follow-up commit for the scan requested in #13079. `5336a0b` covered the ten converters, the sibling type mappers and the catalog classes. While doing the rest of `connector-jdbc` I found three more places that still lower-case with the JVM default locale, and the second commit (`958bf38`) fixes them: - the `WHERE` check used by the row count estimate in `MysqlDialect`, `OceanBaseMysqlDialect`, `OracleDialect`, `RedshiftDialect`, `SqlServerDialect` and `YashanDbDialect` — `PostgresDialect` was already updated in the first commit, so these were the remaining siblings - `CollationBasedSplitter`, where the locale changes the comparison result and not only the spelling of a constant - `JdbcSourceFactory`, in the `where_condition` prefix validator `JdbcDialect` / `CatalogUtils` belong to #13063 and the MySQL / OceanBase / SQL Server converters to #13076 / #13077, so they are intentionally not touched here. Verified locally on JDK 17: `JdbcTypeConverterLocaleTest`, `MysqlDialectTest`, `OracleDialectTest`, `SqlServerDialectTest`, `YashanDbDialectTest` and `JdbcSourceFactoryTest` pass (46 tests, 0 failures) and `spotless:check` is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
