sharpca commented on PR #13083:
URL: https://github.com/apache/seatunnel/pull/13083#issuecomment-6559207966
Thanks both — separate answers below.
**Overlap with #13076 / #13077 (@SEPURI-SAI-KRISHNA)** — agreed, and dropped
in `dfb9ff2c`. `MySqlCatalog`, `OceanBaseMySqlCatalog` and `SqlServerURLParser`
are no longer part of this PR, so the `OceanBaseMySqlCatalog` conflict you hit
cannot occur either way. The PR is now 38 files; the remaining catalog classes
are the ones no other PR owns (`DamengDataTypeConvertor`, `DuckDBCatalog`,
`OceanBaseOracleCreateTableSqlBuilder`, `RedshiftCatalog`,
`RedshiftDataTypeConvertor`, `XuguCatalog`, `YashanDbCatalog`). I also left
`SqlWhereConditionHelper` alone, per your note that `where` contains no `i`.
**Issue 1 — coverage (@DanielLeens)** — added for both paths you named:
- `RedshiftCatalogLocaleTest` builds a mocked `ResultSet` and calls
`RedshiftCatalog#buildColumn` under `tr-TR` for `integer` and `bigint`. That
goes through the catalog discovery method instead of the converter singletons,
so the path `AbstractJdbcCatalog.buildColumn -> database-specific
normalization` is exercised.
- `CharsetBasedSplitterTest#testCaseInsensitiveEncodingUnderTurkishLocale`
asserts that upper-case `I` folds to `i` (not the dotless `ı`), that it encodes
to the same range as `i`, and that the range decodes back to `i` — the
`CollationBasedSplitter:144` behavior you flagged.
What I did **not** add: the container-backed JDBC integration test with row
identities and multiplicities across splits. This machine has no Docker daemon,
so I could not run one, and adding an IT I cannot execute here would be
unreviewable. If you want that on top, say so and I will add it as a follow-up
commit and have CI run it.
**Issue 2 — locale isolation (@DanielLeens)** — done in all three
locale-mutating tests: base, `DISPLAY` and `FORMAT` defaults are captured and
all three restored in `finally`, and each class carries
`@ResourceLock("java.util.Locale")`. The class Javadoc was also moved to the
repository's multiline style.
**Verification** (JDK 17, `-pl seatunnel-connectors-v2/connector-jdbc`):
`JdbcTypeConverterLocaleTest`, `RedshiftCatalogLocaleTest`,
`CharsetBasedSplitterTest`, `MysqlDialectTest`, `OracleDialectTest`,
`SqlServerDialectTest`, `YashanDbDialectTest`, `JdbcSourceFactoryTest`,
`JdbcDialectLoaderTest` — 59 tests, 0 failures, 1 skipped (the container-backed
Oracle test). `spotless:check` passes.
The description was updated: the sibling `WHERE` checks are no longer
described as untouched, since the second commit changed them, and the dropped
files are recorded with the PRs that own them.
CI is still `action_required` on this head, so none of the above has run in
Actions yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
