sharpca commented on PR #13083:
URL: https://github.com/apache/seatunnel/pull/13083#issuecomment-6617052551
The fork build finally ran on 24c2d87 and it caught a real bug in the new
IT, which is worth quoting because it validates the assertion rather than the
fix:
JdbcMysqlSplitIT.testFixedStringSplitBoundsAreLocaleIndependent:992
interior bound I1..i3 is not folded to the case insensitive sequence
==> expected: <i1..i3> but was: <I1..i3>
That was my guard, not the splitter. The first split's start is the literal
partitionStart (MIN = I1), which legitimately keeps its uppercase I, and I had
required every element of the bounds list to be folded. Fixed in de80d16: the
test now walks the splits and checks only the decoded interior bounds - start
of every split except the first, end of every split except the last.
Two other failures in the same run are unrelated to this change:
\Redis7Test.failedInitializationClosesConnections\ in connector-redis unit
tests, and \MetalakeIT.startUp\ timing out in the same IT shard. I have not
touched either module.
Note on coverage, correcting something I assumed earlier: the
\jdbc-connectors-it-part-7\ job is skipped by backend.yml unless api/engine
changed, but the changed-module shard \updated-modules-integration-test-part-8\
did run \JdbcMysqlSplitIT\, so the new IT is exercised after all.
A new run is in progress on de80d16:
[Build](https://github.com/sharpca/seatunnel/actions/runs/41730993933). I will
report the result here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
