SEPURI-SAI-KRISHNA commented on PR #13083: URL: https://github.com/apache/seatunnel/pull/13083#issuecomment-6557458244
Thanks for covering the rest of `connector-jdbc`. There is one overlap with my open PRs, which I think is unintended, since the description leaves the MySQL, OceanBase and SQL Server parts to them: - `MySqlCatalog.java:224`, `OceanBaseMySqlCatalog.java:145` and `:150` (line numbers on `dev`) are also changed in #13076. - `SqlServerURLParser.java:52` is also changed in #13077. I merged the heads locally onto current `dev` in both orders. `MySqlCatalog` and `SqlServerURLParser` merge cleanly because the edits are the same, but `OceanBaseMySqlCatalog` conflicts either way: #13076 removes the second `toUpperCase()` at `:150`, because `dataType` is already upper case from `:145`, while this PR adds `Locale.ROOT` to it. Could you drop these three files from this PR so the PRs stay disjoint, as the description intends? With that, this PR together with #13063, #13076 and #13077 leaves only one bare case conversion in `connector-jdbc/src/main`: the `where` prefix check in `SqlWhereConditionHelper.java:553`, which does not depend on the locale because `where` has no `i`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
