nsivabalan commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2072400831
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1600,15 +1605,16 @@ void compactIfNecessary(BaseHoodieWriteClient<?,I,?,?>
writeClient, Option<Strin
LOG.info("Compaction with same {} time is already present in the
timeline.", compactionInstantTime);
} else if (writeClient.scheduleCompactionAtInstant(compactionInstantTime,
Option.empty())) {
LOG.info("Compaction is scheduled for timestamp {}",
compactionInstantTime);
- writeClient.compact(compactionInstantTime);
+ HoodieWriteMetadata<O> compactionWriteMetadata =
writeClient.compact(compactionInstantTime);
+ writeClient.commitCompaction(compactionInstantTime,
compactionWriteMetadata, Option.empty());
Review Comment:
yeah, for inline compaction, I can introduce a public method in WriteClient
only. should be doable.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1418,6 +1419,10 @@ protected void commitInternal(String instantTime,
Map<String, HoodieData<HoodieR
metrics.ifPresent(m -> m.updateSizeMetrics(metadataMetaClient, metadata,
dataMetaClient.getTableConfig().getMetadataPartitions()));
}
+ protected abstract void writeAndCommitBulkInsert(BaseHoodieWriteClient<?, I,
?, O> writeClient, String instantTime, I preppedRecordInputs,
Option<BulkInsertPartitioner> bulkInsertPartitioner);
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
