danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2072298467
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1418,6 +1419,10 @@ protected void commitInternal(String instantTime,
Map<String, HoodieData<HoodieR
metrics.ifPresent(m -> m.updateSizeMetrics(metadataMetaClient, metadata,
dataMetaClient.getTableConfig().getMetadataPartitions()));
}
+ protected abstract void writeAndCommitBulkInsert(BaseHoodieWriteClient<?, I,
?, O> writeClient, String instantTime, I preppedRecordInputs,
Option<BulkInsertPartitioner> bulkInsertPartitioner);
Review Comment:
Let's add inline compaction methods in write client and remove these methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
