danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2072298218
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1600,15 +1605,16 @@ void compactIfNecessary(BaseHoodieWriteClient<?,I,?,?>
writeClient, Option<Strin
LOG.info("Compaction with same {} time is already present in the
timeline.", compactionInstantTime);
} else if (writeClient.scheduleCompactionAtInstant(compactionInstantTime,
Option.empty())) {
LOG.info("Compaction is scheduled for timestamp {}",
compactionInstantTime);
- writeClient.compact(compactionInstantTime);
+ HoodieWriteMetadata<O> compactionWriteMetadata =
writeClient.compact(compactionInstantTime);
+ writeClient.commitCompaction(compactionInstantTime,
compactionWriteMetadata, Option.empty());
Review Comment:
shall we also keep the original `#commit` method for inline completion, it's
kind of verbose to call 2 times here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
