danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2072493409
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1139,7 +1131,7 @@ public boolean scheduleLogCompactionAtInstant(String
instantTime, Option<Map<Str
* @return Collection of WriteStatus to inspect errors and counts
*/
public HoodieWriteMetadata<O> logCompact(String logCompactionInstantTime) {
- return logCompact(logCompactionInstantTime, config.shouldAutoCommit());
+ return logCompact(logCompactionInstantTime, false);
Review Comment:
Should we remove the auto commit completely? I saw we rename the original
option to add "internal" keyword, but it still looks hacky. It looks like we
used this option to do auto-commit in action executors just like before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
