nsivabalan commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2072403405


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCompactor.java:
##########
@@ -270,6 +270,7 @@ private int doCompact(JavaSparkContext jsc) throws 
Exception {
         }
       }
       HoodieWriteMetadata<JavaRDD<WriteStatus>> compactionMetadata = 
client.compact(cfg.compactionInstantTime);
+      client.commitCompaction(cfg.compactionInstantTime, compactionMetadata, 
Option.empty());

Review Comment:
   actually, for external jobs like this one, we don't wanna use auto commit 
flows. lets keep it this way. 
   I have fixed Metadata writer to just commit with `writeClient.compact()` 
call only w/o needing additional `wirteClient.commitCompaction`. 
   for other external jobs like these, lets allow only non auto commit flows. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to