danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2072297564
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1406,10 +1407,10 @@ protected void commitInternal(String instantTime,
Map<String, HoodieData<HoodieR
preWrite(instantTime);
if (isInitializing) {
engineContext.setJobStatus(this.getClass().getSimpleName(),
String.format("Bulk inserting at %s into metadata table %s", instantTime,
metadataWriteConfig.getTableName()));
- writeClient.bulkInsertPreppedRecords(preppedRecordInputs, instantTime,
bulkInsertPartitioner);
+ writeAndCommitBulkInsert(writeClient, instantTime, preppedRecordInputs,
bulkInsertPartitioner);
Review Comment:
bulkInsertAndCommit
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1406,10 +1407,10 @@ protected void commitInternal(String instantTime,
Map<String, HoodieData<HoodieR
preWrite(instantTime);
if (isInitializing) {
engineContext.setJobStatus(this.getClass().getSimpleName(),
String.format("Bulk inserting at %s into metadata table %s", instantTime,
metadataWriteConfig.getTableName()));
- writeClient.bulkInsertPreppedRecords(preppedRecordInputs, instantTime,
bulkInsertPartitioner);
+ writeAndCommitBulkInsert(writeClient, instantTime, preppedRecordInputs,
bulkInsertPartitioner);
} else {
engineContext.setJobStatus(this.getClass().getSimpleName(),
String.format("Upserting at %s into metadata table %s", instantTime,
metadataWriteConfig.getTableName()));
- writeClient.upsertPreppedRecords(preppedRecordInputs, instantTime);
+ writeAndCommitUpsert(writeClient, instantTime, preppedRecordInputs);
Review Comment:
upsertAndCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
