tengqm commented on code in PR #6573:
URL: https://github.com/apache/gravitino/pull/6573#discussion_r1977427676
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogProperties.java:
##########
@@ -49,10 +49,14 @@ public ListCatalogProperties(CommandContext context, String
metalake, String cat
/** List the properties of a catalog. */
@Override
public void handle() {
- Catalog gCatalog = null;
+ GravitinoClient client = buildClient(metalake);
+
+ if (gCatalog != null) {
+ printProperties(gCatalog.properties());
+ }
+
try {
- GravitinoClient client = buildClient(metalake);
- gCatalog = client.loadCatalog(catalog);
+ Catalog gCatalog = client.loadCatalog(catalog);
} catch (NoSuchMetalakeException err) {
Review Comment:
The original code `buildClient(metalake);` may throw this exception, right?
You moved that line out of the try block for unknown reason.
Now you know why I'm concerned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
