justinmclean commented on code in PR #6573:
URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976574517
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ModelDetails.java:
##########
@@ -68,20 +68,34 @@ public void handle() {
ModelCatalog modelCatalog = client.loadCatalog(catalog).asModelCatalog();
gModel = modelCatalog.getModel(name);
versions = modelCatalog.listModelVersions(name);
- } catch (NoSuchMetalakeException noSuchMetalakeException) {
+
+ // Ensure model exists before proceeding
+ if (gModel == null) {
+ exitWithError(ErrorMessages.UNKNOWN_MODEL);
+ return;
+ }
Review Comment:
please move outside the try block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
