justinmclean commented on code in PR #6573:
URL: https://github.com/apache/gravitino/pull/6573#discussion_r1984131551
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/UserDetails.java:
##########
@@ -49,21 +49,20 @@ public UserDetails(CommandContext context, String metalake,
String user) {
public void handle() {
List<String> roles = null;
- try {
- GravitinoClient client = buildClient(metalake);
+ try (GravitinoClient client = buildClient(metalake)) {
roles = client.getUser(user).roles();
- } catch (NoSuchMetalakeException err) {
+ } catch (NoSuchMetalakeException e) {
exitWithError(ErrorMessages.UNKNOWN_METALAKE);
- } catch (NoSuchUserException err) {
+ } catch (NoSuchUserException e) {
exitWithError(ErrorMessages.UNKNOWN_USER);
- } catch (Exception exp) {
- exitWithError(exp.getMessage());
+ } catch (Exception e) {
+ exitWithError(e.getMessage());
}
- if (roles.isEmpty()) {
- printInformation("The user has no roles.");
+ if (roles == null || roles.isEmpty()) {
+ printInformation("The user has no assigned roles.");
} else {
- printResults(String.join(",", roles));
+ printResults("User Roles: " + String.join(", ", roles));
Review Comment:
Please don't change the output as this may break things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
