justinmclean commented on code in PR #6573:
URL: https://github.com/apache/gravitino/pull/6573#discussion_r1984126813
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTables.java:
##########
@@ -47,43 +47,49 @@ public ListTables(CommandContext context, String metalake,
String catalog, Strin
/** List the names of all tables in a schema. */
@Override
public void handle() {
- NameIdentifier[] tables = null;
- Namespace name = Namespace.of(schema);
-
try {
- tables = tableCatalog().listTables(name);
- } catch (Exception exp) {
- exitWithError(exp.getMessage());
- }
+ Namespace name = Namespace.of(schema);
+ NameIdentifier[] tables = tableCatalog().listTables(name);
- if (tables.length == 0) {
- printInformation("No tables exist.");
- return;
- }
+ if (tables == null || tables.length == 0) {
Review Comment:
this code should be outside the try block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
