justinmclean commented on PR #6573: URL: https://github.com/apache/gravitino/pull/6573#issuecomment-2708073344
@Brijeshthummar02, there are still some outstanding, unaddressed comments. You have also resolved several issues without fixing them. It's getting there, but I think it still needs a little work. My main concern is that the added `try (GravitinoClient client = buildClient(metalake))` will close the client too soon, our unit tests are unlikely to catch this. I'll take a look on Monday to see if this is an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
