tengqm commented on code in PR #6573:
URL: https://github.com/apache/gravitino/pull/6573#discussion_r1977439250
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListColumns.java:
##########
@@ -51,18 +50,40 @@ public ListColumns(
/** Displays the details of a table's columns. */
@Override
public void handle() {
- Column[] columns = null;
-
try {
NameIdentifier name = NameIdentifier.of(schema, table);
- columns = tableCatalog().loadTable(name).columns();
+ Column[] columns = tableCatalog().loadTable(name).columns();
+
+ if (columns == null || columns.length == 0) {
+ exitWithError("No columns found for the specified table.");
+ }
+
+ StringBuilder all = new StringBuilder();
+
all.append("name,datatype,comment,nullable,auto_increment").append(System.lineSeparator());
+
+ for (Column column : columns) {
+ if (column == null) {
+ continue;
+ }
+
+ all.append(column.name()).append(",");
+ all.append(column.dataType() != null ?
column.dataType().simpleString() : "UNKNOWN")
+ .append(",");
+ all.append(column.comment() != null ? column.comment() :
"N/A").append(",");
+ all.append(column.nullable() ? "true" : "false").append(",");
+ all.append(column.autoIncrement() ? "true" : "false");
Review Comment:
Not sure if this column is okay and consistent with other format of outputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
