justinmclean commented on code in PR #6573:
URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976573477
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/SchemaAudit.java:
##########
@@ -52,20 +52,23 @@ public SchemaAudit(CommandContext context, String metalake,
String catalog, Stri
/** Displays the audit information of schema. */
@Override
public void handle() {
- Schema result = null;
-
try (GravitinoClient client = buildClient(metalake)) {
- result = client.loadCatalog(catalog).asSchemas().loadSchema(this.schema);
+ Schema result =
client.loadCatalog(catalog).asSchemas().loadSchema(this.schema);
+
+ if (result == null) {
+ exitWithError("Failed to retrieve schema details.");
+ return;
+ }
+
+ displayAuditInfo(result.auditInfo());
} catch (NoSuchMetalakeException err) {
exitWithError(ErrorMessages.UNKNOWN_METALAKE);
} catch (NoSuchCatalogException err) {
exitWithError(ErrorMessages.UNKNOWN_CATALOG);
} catch (NoSuchSchemaException err) {
exitWithError(ErrorMessages.UNKNOWN_SCHEMA);
} catch (Exception exp) {
- exitWithError(exp.getMessage());
+ exitWithError("An unexpected error occurred: " + exp.getMessage());
Review Comment:
There no need to change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
