justinmclean commented on code in PR #6573:
URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976573680
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/TopicDetails.java:
##########
@@ -58,12 +58,17 @@ public TopicDetails(
/** Displays the details of a topic. */
@Override
public void handle() {
- Topic gTopic = null;
-
- try {
+ try (GravitinoClient client = buildClient(metalake)) {
NameIdentifier name = NameIdentifier.of(schema, topic);
- GravitinoClient client = buildClient(metalake);
- gTopic = client.loadCatalog(catalog).asTopicCatalog().loadTopic(name);
+ Topic gTopic =
client.loadCatalog(catalog).asTopicCatalog().loadTopic(name);
+
+ if (gTopic == null) {
+ exitWithError(ErrorMessages.UNKNOWN_TOPIC);
+ return;
+ }
+
+ printResults("Topic Name: " + gTopic.name() + ", Comment: " +
gTopic.comment());
+
Review Comment:
please move the code to outside the try block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
