justinmclean commented on code in PR #6573:
URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976573873
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/UserDetails.java:
##########
@@ -47,23 +47,21 @@ public UserDetails(CommandContext context, String metalake,
String user) {
/** Displays the roles of a specified user. */
@Override
public void handle() {
- List<String> roles = null;
+ try (GravitinoClient client = buildClient(metalake)) {
+ List<String> roles = client.getUser(user).roles();
- try {
- GravitinoClient client = buildClient(metalake);
- roles = client.getUser(user).roles();
- } catch (NoSuchMetalakeException err) {
+ if (roles == null || roles.isEmpty()) {
+ printInformation("The user has no assigned roles.");
+ } else {
+ printResults("User Roles: " + String.join(", ", roles));
+ }
+
+ } catch (NoSuchMetalakeException e) {
exitWithError(ErrorMessages.UNKNOWN_METALAKE);
- } catch (NoSuchUserException err) {
+ } catch (NoSuchUserException e) {
exitWithError(ErrorMessages.UNKNOWN_USER);
- } catch (Exception exp) {
- exitWithError(exp.getMessage());
- }
-
- if (roles.isEmpty()) {
- printInformation("The user has no roles.");
- } else {
- printResults(String.join(",", roles));
+ } catch (Exception e) {
+ exitWithError("Error retrieving user details: " + e.getMessage());
Review Comment:
This error may be misleading, please don't change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
