justinmclean commented on code in PR #6573:
URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976572959
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTagProperties.java:
##########
@@ -53,12 +53,22 @@ public void handle() {
try {
GravitinoClient client = buildClient(metalake);
gTag = client.getTag(tag);
+
+ // Ensure tag exists before accessing properties
+ if (gTag == null) {
+ exitWithError(ErrorMessages.UNKNOWN_TAG);
+ return;
+ }
+
} catch (NoSuchMetalakeException err) {
exitWithError(ErrorMessages.UNKNOWN_METALAKE);
+ return;
} catch (NoSuchTagException err) {
exitWithError(ErrorMessages.UNKNOWN_TAG);
+ return;
} catch (Exception exp) {
- exitWithError(exp.getMessage());
+ exitWithError("An unexpected error occurred: " + exp.getMessage());
+ return;
Review Comment:
Please remove the return calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
