justinmclean commented on code in PR #6573:
URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976571688
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/CreateTable.java:
##########
@@ -82,27 +82,47 @@ public void handle() {
client = buildClient(metalake);
} catch (NoSuchMetalakeException err) {
exitWithError(ErrorMessages.UNKNOWN_METALAKE);
+ return; // Stop execution
} catch (Exception exp) {
exitWithError("Error initializing client or table name: " +
exp.getMessage());
+ return;
+ }
+
+ if (client == null) {
+ exitWithError("Client initialization failed.");
+ return;
}
try {
tableData = readTableCSV.parse(columnFile);
columns = readTableCSV.columns(tableData);
+ if (columns == null || columns.length == 0) {
+ exitWithError("No valid columns found in the provided file.");
+ return;
+ }
} catch (Exception exp) {
exitWithError("Error reading or parsing column file: " +
exp.getMessage());
+ return;
}
try {
+ if (tableName == null) {
+ exitWithError("Table name could not be determined.");
+ return;
+ }
Review Comment:
I don't think it is possible for the table name to be null, options passing
in on the command line cannot be null, but I guess it doesn't hurt. There's
also no real need for it to be in the try block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
