jtuglu1 commented on code in PR #19286: URL: https://github.com/apache/druid/pull/19286#discussion_r3094647270
########## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScaler.java: ########## Review Comment: > We may reduce the responsibility just to raw task count calculation, and move decision making logic to other entity. That would be clean, IMO. Yeah, my feeling is CBA/Lag can be seen as functions which just return an optimal (or no) task count. The supervisor can handle what to do with this recommendation and emitting metrics on what it chose to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
