jtuglu1 commented on code in PR #19286: URL: https://github.com/apache/druid/pull/19286#discussion_r3091962490
########## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScaler.java: ########## Review Comment: Looking at this again, I don't think this is the proper place for this logic TBH. IMO, an auto-scaler implementation should not be deciding this (the supervisor should and it already does in the main loop) since this scale up/down logic is shared across scalers. Will see what refactoring looks like. I'm open to differing opinions, but generally an auto-scaler should take in some input and output the desired optimal task count. It shouldn't worry about skip reason (due to cooldown not elapsed, or min/max being hit, etc.) as these are all shared logical component between all scalers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
