Fly-Style commented on code in PR #19286:
URL: https://github.com/apache/druid/pull/19286#discussion_r3084454022
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -499,11 +500,34 @@ public void handle()
supervisorId,
dataSource
);
- final Integer desiredTaskCount = computeDesiredTaskCount.call();
+ final int desiredTaskCount =
computeDesiredTaskCount.computeTaskCount();
+ final int currentTaskCount = getCurrentTaskCount();
+
+ if (desiredTaskCount <= 0) {
+ return;
+ }
+
ServiceMetricEvent.Builder event = ServiceMetricEvent.builder()
.setDimension(DruidMetrics.SUPERVISOR_ID, supervisorId)
.setDimension(DruidMetrics.DATASOURCE, dataSource)
.setDimension(DruidMetrics.STREAM, getIoConfig().getStream());
+
+ // 1) This should already be handled by the auto-scaler
implementation, but make sure we catch/record these for auditability
+ if (desiredTaskCount == currentTaskCount) {
+ log.info(
Review Comment:
It definitely deserves `warn` or even `error` log level; it detects an issue
with the autoscaler implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
